Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter agent on Annuaire side rather than ProConnect side #1260

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Filter agent on Annuaire side rather than ProConnect side #1260

wants to merge 4 commits into from
+131 −16

Conversation

rmonnier9
Copy link
Contributor

@rmonnier9 rmonnier9 commented Oct 9, 2024 •
edited by XavierJp
Loading

  • Fonctionnalité : Filtre sur les agents publics et onboarding pour habilitation
  • Zones impactées : api/auth/agent-connect/callback.
  • Détails :
    • Filtrer sur critères pour donner l'accès
    • Si pas d'accès et peut être un service public, écran avec lien du démarche simplifié d'habilitation
    • Si pas d'accès et n'est pas un service public à coup sûr, écran accès refusé

Détail des règles :

  • Si whitelisté avec Grist -> OK
  • Si n'est pas un compte MCP -> OK
  • Si est un service public -> OK
  • Sinon démarche simplifié ou accès refusé

Closes #1226

Note :

  • mettre a jour le lien DS quand on aura la démarche définitive
  • ajouter un lien vers la liste des orgas publiques

@rmonnier9 rmonnier9 changed the title feat(api/auth/agent-connect/callback): filter access feat(api/auth/agent-connect/callback): filter access and habilitation onboarding Oct 9, 2024
XavierJp
XavierJp reviewed Oct 9, 2024
View reviewed changes
pages/api/auth/agent-connect/callback.ts Outdated
Comment on lines 23 to 24
const uniteLegale = await clientUniteLegaleRechercheEntreprise(siren, 0);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather use getUniteLegaleFromSlug here as we want redundancy

Copy link
Contributor Author

@rmonnier9 rmonnier9 Oct 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not possible to use getUniteLegaleFromSlug because it uses next/headers and we are inside pages/api.
What do you advise ?
Using Client OR migrating to app/api OR adapt getUniteLegaleFromSlug ?

@XavierJp XavierJp changed the title feat(api/auth/agent-connect/callback): filter access and habilitation onboarding Filter agent on Annuaire side rather than ProConnect side Oct 9, 2024
@XavierJp
Copy link
Contributor

We can add the link to https://www.demarches-simplifiees.fr/commencer/demande-d-ajout-a-la-liste-des-services-publics

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XavierJp XavierJp XavierJp left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Développer les écrans d'onboarding agents
2 participants
@rmonnier9 @XavierJp